Conversation
|
I guess I was thinking maybe it would be good to have this at least building via github actions first? It's hard to test without a push to a pypi repo, though I can probably dummy something up to test a local install. Were you able to build this locally from this branch? Or the main branch? |
|
I just tried to build the code on main - the code seems to "build" and package OK, but a few of the tests are failing. They look like they might all be datetime related, probably due to a small change in that library with recent versions. |
Yeah, I haven't done anything with this yet or started working on the GH workflow. I just needed to test the ability to create a PR and tag reviewers, make sure the branch rename from |
|
Discussed today the @suwilsoncongruex will take over this PR (or create a new one) since she has the ability to test it locally. |
# Conflicts: # pyproject.toml
|
I can build this locally and run the unit tests and they pass. I manually installed it with data-api and the deprecation warning is gone, so I think we are good to go there, we just need to merge an updated requirements.txt file for python shared whenever we settle on a version and publish to official PyPi repo. |
This is 4teamwork#113
@suwilsoncongruex I know you said you would create this, but I needed to actually test the repo (permissions, ability to create a PR against our repo vs. the original fork, etc)
This also gives us something to test the future workflows with.